Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to rustix, drop nix #670

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Port to rustix, drop nix #670

merged 1 commit into from
Jun 20, 2024

Conversation

cgwalters
Copy link
Member

We already have rustix as a dependency; now that we don't use IPC anymore it's trivial to port to rustix. I prefer its API and maintainer.

Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syncfs rework is tricky and I'm not sure I fully understand it but LGTM overall.

@travier
Copy link
Member

travier commented Jun 20, 2024

CI failing on:

sudo skopeo copy docker-daemon:localhost/bootupd:latest containers-storage:localhost/bootupd:latest
  shell: /usr/bin/bash -e {0}
  env:
    CARGO_TERM_COLOR: always
    CACHE_ON_FAILURE: false
    CARGO_INCREMENTAL: 0
time="202[4](https://github.com/coreos/bootupd/actions/runs/9597160268/job/26465639664?pr=669#step:6:4)-06-20T12:14:17Z" level=info msg="Not using native diff for overlay, this may cause degraded performance for building images: kernel has CONFIG_OVERLAY_FS_REDIRECT_DIR enabled"
time="2024-0[6](https://github.com/coreos/bootupd/actions/runs/9597160268/job/26465639664?pr=669#step:6:6)-20T12:14:17Z" level=info msg="[graphdriver] using prior storage driver: overlay"
time="2024-06-20T12:14:1[7](https://github.com/coreos/bootupd/actions/runs/9597160268/job/26465639664?pr=669#step:6:7)Z" level=fatal msg="initializing source docker-daemon:localhost/bootupd:latest: loading image from docker engine: Error response from daemon: {\"message\":\"client version 1.22 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version\"}"

similarly in #669.

@travier
Copy link
Member

travier commented Jun 20, 2024

Looks like we need a new skopeo in the GitHub runner images :/

@travier
Copy link
Member

travier commented Jun 20, 2024

containers/skopeo#2353

We already have rustix as a dependency; now that we don't
use IPC anymore it's trivial to port to rustix. I prefer its
API and maintainer.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters cgwalters merged commit 8a40a4e into coreos:main Jun 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants