Add a release-checklist + script #97
Conversation
cgwalters
force-pushed
the
release-template
branch
from
2994154
to
006a3c8
Compare
|
|
||
| - publish the artifacts (tag and crate): | ||
| - [ ] `git fetch origin && git checkout ${RELEASE_COMMIT}` | ||
| - [ ] verify `Cargo.toml` has the expected version |
There was a problem hiding this comment.
This is ambiguous and error-prone (we arleady went though mistakes here in previous release-checklist revisions).
There exist multiple commits where the manifest contains the expected version (see comment above wrt dev versions).
| - [ ] `cargo publish` | ||
|
|
||
| - publish this release on GitHub: | ||
| - [ ] find the new tag in the [GitHub tag list](https://github.com/coreos/coreos-installer/tags) and click the triple dots menu, and create a release for it |
Taken from the one currently in coreos-installer: https://github.com/coreos/coreos-installer/blob/master/.github/ISSUE_TEMPLATE/release-checklist.md But tweaked in various ways: - I want to continue to use `git-evtag`, will try to teach `cargo-release` about that at some point. - Rework the vendoring stuff to be a script and run beforehand
cgwalters
force-pushed
the
release-template
branch
from
006a3c8
to
378e8f4
Compare
|
This deviates a bit from our usual flow (specifically, it is not using a dev version outside of releases), but I think we should merge this improvement for now and discuss somewhere else why/if dev-versions are better. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, lucab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Taken from the one currently in coreos-installer:
https://github.com/coreos/coreos-installer/blob/master/.github/ISSUE_TEMPLATE/release-checklist.md
But tweaked in various ways:
git-evtag, will try to teachcargo-releaseabout that at some point.