Add MergeBytes to merge raw FCCs into raw Ignition #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add MergeBytes functions to v1_X subpackages to perform Translation and Ignition Merge of fragments at a specific Ignition version * Add getMerger to determine the right merger function to call based on the first fragment's variant and version * Add MergeBytes to wrap actual merger function uses
dghubble
changed the title
dghubble
commented
Jul 21, 2020
| // MergeBytes translates and merges a slice of raw configs to a single raw | ||
| // Ignition config. The variant and version of the first raw config | ||
| // ("fragment") determines the merger version to use. | ||
| func MergeBytes(fragments [][]byte, options common.TranslateOptions) ([]byte, error) { |
There was a problem hiding this comment.
Is report merging a thing?
There was a problem hiding this comment.
Yes, there is Report.Merge() for that.
|
I haven't forgotten this, but probably will return to it next week |
|
Need to refresh this. Handling merging external to fcct is getting painful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Not yet verified / used
Related: #118