Stabilise openshift 4.15 spec & add openshift 4.16-experimental spec #514
Conversation
travier
force-pushed
the
main-openshift-4.15-stable
branch
from
97bc4a8
to
f75a5e2
Compare
|
See also #515 |
travier
force-pushed
the
main-openshift-4.15-stable
branch
from
f75a5e2
to
2d977be
Compare
Fixes: 0d2fa0f spec/v1.6: Add support for boot_device sugar on s390x
Stabilise openshift 4.14.0 spec on fcos 1.5 and ignition 3.4 stable specs. fcos 1.6 & ignition 3.5 are still experimental.
travier
force-pushed
the
main-openshift-4.15-stable
branch
from
2d977be
to
9be0a58
Compare
There was a problem hiding this comment.
Overall, its looks good, and thank you for doing this.
I have a few small picks about the structuring of your commits, it would help readability for me. Not sure if it's a nessary change though.
Looking at your commit structure
[docs: Fix openshift v4.14 generated docs]
[docs: Mark grub section as unsupported]
[internal/doc/butane: Fix whitespace]
[openshift/v4.15: Stabilize 4.15.0 spec]
[openshift/v4.15: Use fcos 1.5 & ignition 3.4 specs]
[openshift/v4.15: Remove GRUB password support]
[openshift/v4_16_exp: Add 4.16.0-experimental spec]
I think it would be better to be
[docs: Fix openshift v4.14 generated docs] ++ [docs: Mark grub section as unsupported]
[internal/doc/butane: Fix whitespace]
[openshift/v4_15_exp: rename to v4_16_exp]
[openshift/v4_15: copy from v4_16_exp]
[Stabilize openshift 4.15.0; create openshift 4.16.0-experimental]
[openshift/v4.15: Remove GRUB password support]
wdyt?
|
Also nit Stabilize not Stabilise just because past pr's tend to use Stabilize |
|
I followed the steps from #511. Maybe we could revisit them at some later time. I don't have the full context for the order but I can see some logic behind it (mostly to avoid mistakes). |
It depends on fcos 1.6.0-experimental See: coreos#484 See: coreos#514
It depends on fcos 1.6.0-experimental See: coreos#484 See: coreos#514 Fixes: coreos#517
It depends on fcos 1.6.0-experimental See: coreos#484 See: coreos#514 Fixes: coreos#517
docs: Fix openshift v4.14 generated docs
Fixes: 186b8e8
openshift/v4.15: Stabilize 4.15.0 spec
openshift/v4.15: Use fcos 1.5 & ignition 3.4 specs
Stabilise openshift 4.14.0 spec on fcos 1.5 and ignition 3.4 stable
specs. fcos 1.6 & ignition 3.5 are still experimental.
internal/doc/butane: Fix whitespace
Fixes: 0d2fa0f spec/v1.6: Add support for boot_device sugar on s390x
openshift/v4.15: Remove GRUB password support
openshift/v4_16_exp: Add 4.16.0-experimental spec
--
Fixes: #511
Based on #513 for convenience.