Stabilize openshift v4.17.0 spec #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Step down to non expermental features Additionaly remove GRUB password support See: https://issues.redhat.com/browse/MCO-630
travier
approved these changes
Sep 20, 2024
| @@ -25,6 +25,8 @@ We recommend that you always use the latest **stable** specification for your op | |||
| - [v1.1.0](config-flatcar-v1_1.md) | |||
| - [v1.0.0](config-flatcar-v1_0.md) | |||
| - OpenShift (`openshift`) | |||
| - [v4.17.0](config-openshift-v4_17.md) | |||
| - [v4.16.0](config-openshift-v4_16.md) | |||
There was a problem hiding this comment.
Ouch this was missing from the 4.16 PR. Good that we're fixing it here :)
docs/release-notes.md
Outdated
| @@ -94,7 +98,7 @@ key](https://getfedora.org/security/). | |||
| ### Docs changes | |||
|
|
|||
| - Document consequence of setting `systemd.units.mask` to false | |||
| - Document `grub` section _(openshift 4.15.0-exp)_ | |||
| - Document `grub` section _(openshift 4.18.0-exp)_ | |||
There was a problem hiding this comment.
Maybe I did this in the past, but let's try not changing past release notes.
We can add a note for the current release instead.
Someting like:
Support and documentation for `grub` section moved to OpenShift 4.18.0-experimental spec.
There was a problem hiding this comment.
Ah, ok, makes sense. will not do in the future; thank you for fixing the nits!
travier
force-pushed
the
s-openshift-v4.17.0
branch
from
a30fdbd to
18d63d2
Compare
travier
pushed a commit
to yasminvalim/butane
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #545