Skip to content

Commit

Permalink
osbuild: don't compress in the qemu stage for now
Browse files Browse the repository at this point in the history
We'll open a PR upstream to make compression an option for this stage,
but for now we'll just disable it in the code because we know we don't
want it: coreos/fedora-coreos-tracker#1653 (comment)
  • Loading branch information
dustymabe committed Feb 6, 2024
1 parent ade15b9 commit 2a8d1e6
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 0 deletions.
1 change: 1 addition & 0 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ patch_osbuild() {
/usr/lib/coreos-assembler/0001-stages-zipl.inst-improve-kernel-initrd-path-resoluti.patch \
/usr/lib/coreos-assembler/0002-stages-zipl.inst-support-appending-kernel-options.patch \
/usr/lib/coreos-assembler/0001-stages-copy-allow-copying-from-the-tree.patch \
/usr/lib/coreos-assembler/0001-stages-qemu-don-t-use-internal-compression-for-now.patch \
| patch -d /usr/lib/osbuild -p1

# And then move the files back; supermin appliance creation will need it back
Expand Down
30 changes: 30 additions & 0 deletions src/0001-stages-qemu-don-t-use-internal-compression-for-now.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
From 372df8e1adb3c76f092ed47a45ee8637a247c786 Mon Sep 17 00:00:00 2001
From: Dusty Mabe <dusty@dustymabe.com>
Date: Mon, 5 Feb 2024 17:38:41 -0500
Subject: [PATCH] stages(qemu): don't use internal compression for now

Until this is an option in the stage let's disable it for now
https://github.com/coreos/fedora-coreos-tracker/issues/1653#issuecomment-1928342241
---
stages/org.osbuild.qemu | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/stages/org.osbuild.qemu b/stages/org.osbuild.qemu
index 98a04f00..07172b3d 100755
--- a/stages/org.osbuild.qemu
+++ b/stages/org.osbuild.qemu
@@ -140,7 +140,10 @@ SCHEMA_2 = r"""


def qcow2_arguments(options):
- argv = ["-c"]
+ # No internal compression in CoreOS for now.
+ # https://github.com/coreos/fedora-coreos-tracker/issues/1653#issuecomment-1928342241
+ # argv = ["-c"]
+ argv = []
compat = options.get("compat")

if compat:
--
2.43.0

0 comments on commit 2a8d1e6

Please sign in to comment.