Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error: No such file or directory: /usr/share/coreos-assembler #2885

Closed
miabbott opened this issue Jun 1, 2022 · 2 comments · Fixed by #2886
Closed

error: No such file or directory: /usr/share/coreos-assembler #2885

miabbott opened this issue Jun 1, 2022 · 2 comments · Fixed by #2886

Comments

@miabbott
Copy link
Member

miabbott commented Jun 1, 2022

Bug Report

Environment

What operating system is being used to run coreos-assembler?

I think it is RHEL7 on aarch64 (downstream RHCOS aarch64 pipeline)

What operating system is being assembled?

RHCOS 4.11

Is coreos-assembler running in Podman or Docker?

Docker

Expected Behavior

RHCOS build is successful

Actual Behavior

During the cosa build stage:

Previous build: 411.85.202206010001-0
Previous commit: 29348f8e86fb8af3df5dc12d42d0df082792a7a8f695032a419ab92390689a75
Extracting 29348f8e86fb8af3df5dc12d42d0df082792a7a8f695032a419ab92390689a75
Imported: 411.85.202206010001-0 => 29348f8e86fb8af3df5dc12d42d0df082792a7a8f695032a419ab92390689a75
3437 metadata, 22842 content objects imported; 2.4��GB content written
error: No such file or directory: /usr/share/coreos-assembler
Traceback (most recent call last):
  File "<string>", line 10, in <module>
  File "/usr/lib/coreos-assembler/cosalib/cmdlib.py", line 291, in import_ostree_commit
    extract_image_json(workdir, commit)
  File "/usr/lib/coreos-assembler/cosalib/cmdlib.py", line 239, in extract_image_json
    subprocess.check_call(['ostree', f'--repo={repo}', 'cat', commit, '/usr/share/coreos-assembler/image.json'], stdout=f)
  File "/usr/lib64/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ostree', '--repo=/home/jenkins/agent/workspace/rhcos/rhcos-rhcos-4.11/tmp/repo', 'cat', '29348f8e86fb8af3df5dc12d42d0df082792a7a8f695032a419ab92390689a75', '/usr/share/coreos-assembler/image.json']' returned non-zero exit status 1.

Reproduction Steps

  1. cosa fetch
  2. cosa build

Other Information

This looks like fallout from #2839
@miabbott
Copy link
Member Author

miabbott commented Jun 1, 2022

cc: @cgwalters

@cgwalters
Copy link
Member

OK yep, need to handle the case of a previous commit; I have a patch I'm testing.

But, let's also try to cut over 4.11 to the new registry.ci.openshift.org/coreos/coreos-assembler:4.11 anyways.

cgwalters added a commit to cgwalters/coreos-assembler that referenced this issue Jun 1, 2022
@cgwalters
build: Handle case of previous build with no image.json in ostree
823fe2b 
For now, we need to handle this.  But I think we can switch
back to hard requiring it later, which will happen naturally
when we rework the build system to more cleanly separate
ostree container builds and disk image builds.

Closes: coreos#2885
@cgwalters cgwalters mentioned this issue Jun 1, 2022
Merged
dustymabe pushed a commit that referenced this issue Jun 1, 2022
@cgwalters @dustymabe
build: Handle case of previous build with no image.json in ostree
4581cdf 
For now, we need to handle this.  But I think we can switch
back to hard requiring it later, which will happen naturally
when we rework the build system to more cleanly separate
ostree container builds and disk image builds.

Closes: #2885
travier pushed a commit to travier/coreos-assembler that referenced this issue Jul 7, 2022
@cgwalters @travier
build: Handle case of previous build with no image.json in ostree
5e570db 
For now, we need to handle this.  But I think we can switch
back to hard requiring it later, which will happen naturally
when we rework the build system to more cleanly separate
ostree container builds and disk image builds.

Closes: coreos#2885
cgwalters added a commit that referenced this issue Jul 7, 2022
@cgwalters
build: Handle case of previous build with no image.json in ostree
c774337 
For now, we need to handle this.  But I think we can switch
back to hard requiring it later, which will happen naturally
when we rework the build system to more cleanly separate
ostree container builds and disk image builds.

Closes: #2885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Handle case of previous build with no image.json in ostree cgwalters/coreos-assembler
2 participants
@cgwalters @miabbott