Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosa buildextend-extensions blowing up #2904

Closed
miabbott opened this issue Jun 3, 2022 · 1 comment · Fixed by #2905
Closed

cosa buildextend-extensions blowing up #2904

miabbott opened this issue Jun 3, 2022 · 1 comment · Fixed by #2905

Comments

@miabbott
Copy link
Member

miabbott commented Jun 3, 2022

Bug Report

Environment

What operating system is being used to run coreos-assembler?

Fedora 35 SB

What operating system is being assembled?

RHCOS 4.11

Is coreos-assembler running in Podman or Docker?

podman

If Podman, is coreos-assembler running privileged or unprivileged?

unprivileged

Expected Behavior

cosa buildextend-extensions is successful

Actual Behavior

[coreos-assembler]$ cosa buildextend-extensions
Extracting 5f6ffa69be499527740fdb6f41de53b705c8d218a7de62cf0f6eb5109f536592
error: Creating repo: fsetxattr(user.ostreemeta): Operation not supported
Traceback (most recent call last):
  File "/usr/lib/coreos-assembler/cmd-buildextend-extensions", line 124, in <module>
    sys.exit(main())
  File "/usr/lib/coreos-assembler/cmd-buildextend-extensions", line 37, in main
    cmdlib.import_ostree_commit('tmp/repo', builddir, buildmeta)
  File "/usr/lib/coreos-assembler/cosalib/cmdlib.py", line 302, in import_ostree_commit
    subprocess.check_call(['ostree', 'init', '--repo', tmpd, '--mode=bare-user'])
  File "/usr/lib64/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ostree', 'init', '--repo', '/tmp/tmp6w1ge7wq', '--mode=bare-user']' returned non-zero exit status 1.

Reproduction Steps

  1. cosa init https://github.com/openshift/os
  2. copy over repo files
  3. cosa fetch && cosa build
  4. cosa buildextend-extensions

Other Information

Maybe fallout from #2892 or #2889?
cgwalters added a commit to cgwalters/coreos-assembler that referenced this issue Jun 3, 2022
@cgwalters
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
96aa331 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: coreos#2904
@cgwalters cgwalters mentioned this issue Jun 3, 2022
Merged
@cgwalters
Copy link
Member

PR in #2905

cgwalters added a commit to cgwalters/coreos-assembler that referenced this issue Jun 3, 2022
@cgwalters
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
19325b4 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: coreos#2904
cgwalters added a commit that referenced this issue Jun 4, 2022
@cgwalters
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
e024805 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: #2904
dustymabe pushed a commit to dustymabe/coreos-assembler that referenced this issue Sep 16, 2022
@cgwalters @dustymabe
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
1e248f4 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: coreos#2904
(cherry picked from commit e024805)
dustymabe pushed a commit that referenced this issue Sep 16, 2022
@cgwalters @dustymabe
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
7116c13 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: #2904
(cherry picked from commit e024805)
dustymabe pushed a commit to dustymabe/coreos-assembler that referenced this issue Nov 7, 2022
@cgwalters @dustymabe
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
03c4a74 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: coreos#2904
(cherry picked from commit e024805)

dustymabe: This cherry pick needed manual merge conflict resolution.
           The functiona call for import_ostree_commit() changed in
           816ebae to pass the workdir in. I evaluated the changes
           in e024805 and 816ebae and determined this to be the most
           surgical change.
dustymabe pushed a commit to dustymabe/coreos-assembler that referenced this issue Nov 8, 2022
@cgwalters @dustymabe
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
2496825 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: coreos#2904
(cherry picked from commit e024805)

dustymabe: This cherry pick needed manual merge conflict resolution.
           The function call for import_ostree_commit() changed in
           816ebae to pass the workdir in. I evaluated the changes
           in e024805 and 816ebae and determined this to be the most
           surgical change.
dustymabe pushed a commit to dustymabe/coreos-assembler that referenced this issue Nov 8, 2022
@cgwalters @dustymabe
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
655c281 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: coreos#2904
(cherry picked from commit e024805)

dustymabe: This cherry pick needed manual merge conflict resolution.
           The function call for import_ostree_commit() changed in
           816ebae to pass the workdir in. I evaluated the changes
           in e024805 and 816ebae and determined this to be the most
           surgical change.
dustymabe pushed a commit that referenced this issue Nov 8, 2022
@cgwalters @dustymabe
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
56aac42 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: #2904
(cherry picked from commit e024805)

dustymabe: This cherry pick needed manual merge conflict resolution.
           The function call for import_ostree_commit() changed in
           816ebae to pass the workdir in. I evaluated the changes
           in e024805 and 816ebae and determined this to be the most
           surgical change.
dustymabe pushed a commit to dustymabe/coreos-assembler that referenced this issue Nov 10, 2022
@cgwalters @dustymabe
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
118bd22 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: coreos#2904
(cherry picked from commit e024805)

dustymabe: This cherry pick needed manual merge conflict resolution.
           The function call for import_ostree_commit() changed in
           816ebae to pass the workdir in. I evaluated the changes
           in e024805 and 816ebae and determined this to be the most
           surgical change.
(cherry picked from commit 56aac42)
dustymabe pushed a commit to dustymabe/coreos-assembler that referenced this issue Nov 10, 2022
@cgwalters @dustymabe
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
158c1dc 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: coreos#2904
(cherry picked from commit e024805)

dustymabe: This cherry pick needed manual merge conflict resolution.
           The function call for import_ostree_commit() changed in
           816ebae to pass the workdir in. I evaluated the changes
           in e024805 and 816ebae and determined this to be the most
           surgical change.
(cherry picked from commit 56aac42)
dustymabe pushed a commit to dustymabe/coreos-assembler that referenced this issue Nov 13, 2022
@cgwalters @dustymabe
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
a008db7 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: coreos#2904
(cherry picked from commit e024805)

dustymabe: This cherry pick needed manual merge conflict resolution.
           The function call for import_ostree_commit() changed in
           816ebae to pass the workdir in. I evaluated the changes
           in e024805 and 816ebae and determined this to be the most
           surgical change.
(cherry picked from commit 56aac42)
dustymabe pushed a commit that referenced this issue Nov 15, 2022
@cgwalters @dustymabe
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
bdd1d83 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: #2904
(cherry picked from commit e024805)

dustymabe: This cherry pick needed manual merge conflict resolution.
           The function call for import_ostree_commit() changed in
           816ebae to pass the workdir in. I evaluated the changes
           in e024805 and 816ebae and determined this to be the most
           surgical change.
(cherry picked from commit 56aac42)
jlebon pushed a commit that referenced this issue Dec 2, 2022
@cgwalters @jlebon
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
802cab0 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: #2904
(cherry picked from commit e024805)

dustymabe: This cherry pick needed manual merge conflict resolution.
           The function call for import_ostree_commit() changed in
           816ebae to pass the workdir in. I evaluated the changes
           in e024805 and 816ebae and determined this to be the most
           surgical change.
jlebon pushed a commit that referenced this issue Dec 2, 2022
@cgwalters @jlebon
cmdlib: Ensure bare-user tmpdir is in $workdir/tmp
838d72c 
Linux `tmpfs` still doesn't support `user.` xattrs, and so for
toolbox-like containers that use a (proper!) `tmpfs` for `/tmp`
instead of having it be `overlayfs`, we need to ensure that
we create our tempdir in `$workdir/tmp` - the workdir must have
`user.` xattr support for the `cache/repo-build` anyways.

Closes: #2904
(cherry picked from commit e024805)

dustymabe: This cherry pick needed manual merge conflict resolution.
           The function call for import_ostree_commit() changed in
           816ebae to pass the workdir in. I evaluated the changes
           in e024805 and 816ebae and determined this to be the most
           surgical change.
(cherry picked from commit 56aac42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmdlib: Ensure bare-user tmpdir is in $workdir/tmp cgwalters/coreos-assembler
2 participants
@cgwalters @miabbott