-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make push-container-manifest
idempotent
#3150
Comments
Some things I'd add to the above:
This makes it more similar to the semantics of other cosa commands. |
Oh right. None of them will have the top-level key if the operation failed at all. So yes, we can just check that the toplevel keys exist (in the arch meta.json files) and then no-op out of it. It makes the check much more simple. |
I think we still also want what you originally described though in case the |
(Makes sense but note with #2685 this issue goes away, because the container is the root, the axis around which disk images revolve, the source of truth, and not just another thing pushed out) |
We're talking about more than one container here. |
The extensions container? Yeah, true. Though not for FCOS. And hopefully at some point we can kill that for RHCOS too. |
We'll have a kubevirt container pretty soon too. |
Yeah, makes sense; we do want idempotence for that indeed. |
- Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
- Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
- Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`.
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`. (cherry picked from commit 9d3bdd9)
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes #3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`. (cherry picked from commit 9d3bdd9)
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`. (cherry picked from commit 9d3bdd9) (cherry picked from commit 3945a7c)
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`. (cherry picked from commit 9d3bdd9) (cherry picked from commit 3945a7c)
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`. (cherry picked from commit 9d3bdd9) (cherry picked from commit 3945a7c)
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`. (cherry picked from commit 9d3bdd9) (cherry picked from commit 3945a7c)
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`. (cherry picked from commit 9d3bdd9) (cherry picked from commit 3945a7c)
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`. (cherry picked from commit 9d3bdd9) (cherry picked from commit 3945a7c)
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes #3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`. (cherry picked from commit 9d3bdd9) (cherry picked from commit 3945a7c)
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes coreos#3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`.
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes #3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`. (cherry picked from commit 9d3bdd9)
Check if the digests are already present in the remote manifest and if you want to force or not a new manifest upload. Fixes #3150 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit bfbbe41) jlebon: Had to modify new code to use `runcmd` from `cosalib.utils.`. (cherry picked from commit 9d3bdd9) (cherry picked from commit 3945a7c)
We want to be able to run the release job multiple times (in case one run fails in an intermediate stage) and have each stage no-op if there is nothing to do (i.e. don't recreate things that already exist).
We need to update
push-container-manifest
to do some check here and make sure we don't push a new manifest listed container if the one that is there is correct already. We'd probably make an update somewhere in this area of the code.I'm thinking we can do something like this:
When inspecting the remote container we can get the digests by doing something like:
The text was updated successfully, but these errors were encountered: