kola/qemu: Support injecting kernel network arguments #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
changed the title
cgwalters
commented
Mar 5, 2020
| @@ -277,70 +280,99 @@ func findLabel(label, pid string) (string, error) { | |||
| return strings.TrimSpace(string(stdout)), nil | |||
| } | |||
|
|
|||
| // setupIgnition copies the ignition file inside the disk image. | |||
| func setupIgnition(confPath string, diskImagePath string) error { | |||
| type coreosGuestfish struct { | |||
There was a problem hiding this comment.
Also factored out a guestfish API since I originally started to make it a separate function.
ashcrow
approved these changes
Mar 5, 2020
Invoking `setenv()` in multi-threaded processes is unsafe: rust-lang/rust#24741 https://sourceware.org/bugzilla/show_bug.cgi?id=4887#c9 https://bugs.freedesktop.org/show_bug.cgi?id=65681
This is useful for quickly testing static IP addresses on the kernel cmdline without actually having to catch the GRUB prompt or go through a whole series of `coreos-installer iso embed` etc.
|
Rebased 🏄♂️ |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for quickly testing static IP addresses on the
kernel cmdline without actually having to catch the GRUB
prompt or go through a whole series of
coreos-installer iso embedetc.