-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kola/qemu: Support injecting kernel network arguments #1219
Conversation
@@ -277,70 +280,99 @@ func findLabel(label, pid string) (string, error) { | |||
return strings.TrimSpace(string(stdout)), nil | |||
} | |||
|
|||
// setupIgnition copies the ignition file inside the disk image. | |||
func setupIgnition(confPath string, diskImagePath string) error { | |||
type coreosGuestfish struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also factored out a guestfish API since I originally started to make it a separate function.
Invoking `setenv()` in multi-threaded processes is unsafe: rust-lang/rust#24741 https://sourceware.org/bugzilla/show_bug.cgi?id=4887#c9 https://bugs.freedesktop.org/show_bug.cgi?id=65681
This is useful for quickly testing static IP addresses on the kernel cmdline without actually having to catch the GRUB prompt or go through a whole series of `coreos-installer iso embed` etc.
Rebased 🏄♂️ |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is useful for quickly testing static IP addresses on the
kernel cmdline without actually having to catch the GRUB
prompt or go through a whole series of
coreos-installer iso embed
etc.