mantle/api: gcloud: remove FCOS specific image GuestOSFeatures

[dustymabe]

We consider the VIRTIO_SCSI_MULTIQUEUE, UEFI_COMPATIBLE,
and SECURE_BOOT flags to be standard now so we can
unconditionally add them to GCP images we create and get
rid of the --fcos option.

[dustymabe]

This is a follow-up from #1319 (comment)

[cgwalters]

LGTM...I wrote all this stuff below then changed my mind, just attaching it for reference.

---

I'm OK with this, though I think I'd vote instead we:

• change the argument to default to true in ore
• remove the arg from cosa

The idea here is it's slightly more convenienent for someone testing something interactively w/ore to pass --fcos=false or so than to hack the source. But

[dustymabe]

Note that AFAICT this will change the defaults for the RHCOS pipeline. I'm guessing that openshift/installer#2921 only changes it at runtime when the instance is launched.

[cgwalters]

Note that AFAICT this will change the defaults for the RHCOS pipeline. I'm guessing that openshift/installer#2921 only changes it at runtime when the instance is launched.

No, as you discovered in internal chat, the openshift installer today always creates the image in GCP. That's precisely why that PR was needed (and indeed works without this one).

[bgilbert]

/lgtm

Thanks for the cleanup!

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgilbert, dustymabe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bgilbert,dustymabe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment