Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd-fetch: include overrides when updating lockfile #1387

Merged
merged 1 commit into from
Apr 23, 2020

Commits on Apr 22, 2020

  1. cmd-fetch: include overrides when updating lockfile

    I'm working on a lockfile updater[1], and I'd like it to just be able to
    do `cosa fetch --update-lockfile` the same way a human would. This
    normally would run `rpm-ostree compose tree` without passing any
    lockfiles and blocking out the pool so that all packages come from the
    base repo.
    
    Sadly, that doesn't currently work for FCOS right now because we have an
    override for crypto-policies from f32 so that we don't pull in Python.
    And because we also have an `exclude-packages` for Python, without the
    f32 crypto-policies, we can't get a depsolve from just the base f31
    repos. (This is the same issue that killed bodhi-updates[2].)
    
    As a short-term hack, just include the overrides for now. This dillutes
    the meaning of a "base" lockfile of course, because it will now include
    the packages from the overrides. I don't think this really matters for
    now though (it does make the checking for whether overrides are still
    needed harder, but I'd like to automate dropping overrides eventually
    too).
    
    Anyway, we can drop this hack once we move to f32, though I have some
    ideas too on how to solve this more correctly.
    
    [1] coreos/fedora-coreos-tracker#293
    [2] coreos/fedora-coreos-config#335 (comment)
    jlebon committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    ffe7d21 View commit details
    Browse the repository at this point in the history