-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mantle/ore: gcloud: add ability to attach license to image #1446
mantle/ore: gcloud: add ability to attach license to image #1446
Conversation
builds on top of #1444, for this PR you only need to review the last commit |
71d5a6d
to
596e2df
Compare
@dustymabe: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM |
In order to get a dashboard with metrics and such we need to attach our images to "licenses" in GCP. These aren't software licenses but rather how billing and such is done for images that cost money. Ours don't cost anything so it's purely for counting purposes.
596e2df
to
924093f
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgilbert, dustymabe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
is prow down? |
/retest |
ok CI passed, but prow is MIA - merging. |
In order to get a dashboard with metrics and such we need to attach
our images to "licenses" in GCP. These aren't software licenses but
rather how billing and such is done for images that cost money. Ours
don't cost anything so it's purely for counting purposes.