cmd-kola: also detect --platform=

[dustymabe]

This fixes it so that passing --platform= also works.

[cgwalters]

Seems OK but I'd hope we can invest a bit more in removing that script instead.

[dustymabe]

Seems OK but I'd hope we can invest a bit more in removing that script instead.

Yep, the relationship with cmd-kola and kola is fragile. No doubt about that.

[jlebon]

One thing that confused me was that I know we do -p=aws right now in the pipeline and was confused how that worked since we just checked for -p. But then looking at the output closely:

kola -p qemu-unpriv --build 31.20200505.3.0 \
  --output-dir tmp/kola-upgrade run-upgrade \
  -p=aws --aws-region=us-east-1 --no-test-exit-error \
  --blacklist-test coreos.ignition.journald-log \
  --qemu-image-dir tmp/kola-qemu-cache -v --find-parent-image

So we were passing -p to kola twice and just relying on the last one winning, which I think this will clean up as well.

Anyway, agreed we should nuke this entirely eventually.
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arithx, dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [arithx,dustymabe,jlebon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jlebon]

/test sanity