Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdlib: Stop parsing rojig/license #1473

Merged
merged 1 commit into from
May 22, 2020

Conversation

cgwalters
Copy link
Member

Nothing is using this right now. Noticed this while looking
at variant builds.

Nothing is using this right now.  Noticed this while looking
at variant builds.
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member

jlebon commented May 22, 2020

LGTM, though I've been thinking we should just stop abusing the rojig fields entirely and probably have an assembly.yaml type file instead which absorbs image.yaml

/lgtm

@cgwalters
Copy link
Member Author

LGTM, though I've been thinking we should just stop abusing the rojig fields entirely and probably have an assembly.yaml type file instead which absorbs image.yaml

When working on #1459 I was going to simply have:
name=$(basename ${manifest} .yaml) but that doesn't help with summary which we use for public cloud uploads. I'm thinking that should be a separate thing...hmm, probably image.yaml is fine for that?

@jlebon
Copy link
Member

jlebon commented May 22, 2020

I'm thinking that should be a separate thing...hmm, probably image.yaml is fine for that?

Yup sure, WFM.

@cgwalters
Copy link
Member Author

OK ugh, we are going to need to do something about the docker hub and our tests. In the meantime I promise nothing uses this, and this is a trivial PR so
/override continuous-integration/jenkins/pr-merge

@openshift-ci-robot
Copy link

@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge

In response to this:

OK ugh, we are going to need to do something about the docker hub and our tests. In the meantime I promise nothing uses this, and this is a trivial PR so
/override continuous-integration/jenkins/pr-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters cgwalters added the lgtm label May 22, 2020
@cgwalters
Copy link
Member Author

Hmm and Prow is missing a lot of Github webhooks today or something too. Maybe it's Github's fault though according to status.

@openshift-merge-robot openshift-merge-robot merged commit 919bd06 into coreos:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants