Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import FCOS trans.py that converts meta.json → release.json #2006

Merged

Conversation

cgwalters
Copy link
Member

This is a straight up import of almost-exactly the contents
of https://github.com/coreos/fedora-coreos-releng-automation/blob/master/coreos-meta-translator/trans.py

Prep for adding more stream tooling into coreos-assembler as
part of openshift/os#477

This is a straight up import of almost-exactly the contents
of https://github.com/coreos/fedora-coreos-releng-automation/blob/master/coreos-meta-translator/trans.py

Prep for adding more stream tooling into coreos-assembler as
part of openshift/os#477
@cgwalters
Copy link
Member Author

To actually use this for RHCOS we'll need various improvements like not having a hardcoded URL, but I think those changes should be followups.

How hard would it be to change the FCOS pipeline to consume this after it lands? We'd just need to schedule a cosa pod in the pipeline right?

@jlebon
Copy link
Member

jlebon commented Jan 14, 2021

How hard would it be to change the FCOS pipeline to consume this after it lands? We'd just need to schedule a cosa pod in the pipeline right?

We already do everything in a cosa pod, so it should just be a simple change from /var/tmp/fcos-releng/coreos-meta-translator/trans.py to coreos-assembler generate-release-meta. I can line up that PR.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jlebon added a commit to jlebon/fedora-coreos-pipeline that referenced this pull request Jan 14, 2021
@jlebon
Copy link
Member

jlebon commented Jan 14, 2021

Another obvious follow-up now that it's in cosa is to auto-default to $PWD for --workdir, and latest for --build-id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants