Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure the console by default only on particular platforms #2400

Merged
merged 4 commits into from
Jun 3, 2022
Merged

Configure the console by default only on particular platforms #2400

merged 4 commits into from
Jun 3, 2022

Commits on May 28, 2022

  1. create_disk.sh: add missing trailing newline in grub.cfg

    Fixes: c9036fa ("Serialize `grub-script` literally into image.json")
    bgilbert committed May 28, 2022
    Configuration menu
    Copy the full SHA
    91a168c View commit details
    Browse the repository at this point in the history
  2. gf-platformid: rename to gf-set-platform

    Soon it will both set the platform ID and configure the console.
    bgilbert committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f7839c1 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Fix stale GitHub line number references in comments

    mantle/platforms.md also has a bunch, but that's more than I want to
    unwind right now.
    bgilbert committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    8ad06e2 View commit details
    Browse the repository at this point in the history
  2. Configure the console by default only on particular platforms

    Stop specifying console= kernel arguments by default, except on specific
    arch/platform pairs where we know we need them.  Do the same with console
    configuration in grub.cfg.  More info is in
    coreos/fedora-coreos-tracker#567.
    
    Read platforms.yaml from the config repo to determine what console
    settings should be applied for each arch/platform.  Convert the table for
    the current arch to JSON and copy it to /boot/coreos/platforms.json in
    the image, since coreos-installer needs the same data when overriding the
    platform ID at install time.  If platforms.yaml is missing, continue to
    apply the previous defaults.
    
    We do this in two places: create_disk.sh configures console settings for
    metal and qemu images from platforms.yaml.  For other platforms,
    gf-set-platform reads platforms.json from the image, undoes any
    qemu-specific settings, and applies settings for the target platform.
    bgilbert committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    e41963c View commit details
    Browse the repository at this point in the history