Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Insert generated image.json into the ostree commit" #2838

Merged
merged 1 commit into from
May 3, 2022

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented May 3, 2022

This reverts commit e0c3296.

This broke the next stream release at the cosa aws-replicate step:

coreos/fedora-coreos-streams#496 (comment)

This reverts commit e0c3296.

This broke the `next` stream release at the `cosa aws-replicate` step:

coreos/fedora-coreos-streams#496 (comment)
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters
Copy link
Member

I think #2839 will fix this too.

@dustymabe
Copy link
Member

I think #2839 will fix this too.

Let's revert this for now and test the new approach on testing-devel tomorrow or Thursday with AWS replication enabled.

@dustymabe dustymabe merged commit 0fd8955 into coreos:main May 3, 2022
@jlebon jlebon deleted the pr/revert-2811 branch April 22, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants