Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: Add isolation=readonly|dynamicuser #3060

Closed
wants to merge 1 commit into from

Commits on Sep 1, 2022

  1. kola: Add isolation=readonly|dynamicuser

    Part of my war against duplicative comments in our kola tests.
    We have a few tests that write a comment like this:
    
    ```
     # - exclusive: false
     #   - This test doesn't make meaningful changes to the system and
     #     should be able to be combined with other tests.
    ```
    Of course, this comment is already redundant because the
    meaning of the `exclusive` tag is defined canonically in coreos-assembler
    (here) and copy-pasting that into every test that uses it would
    be pointlessly verbose.
    
    But - we can do one better.  Instead of having a test flag which
    is mainly an "I promise not to mutate the system in a way which could
    interfere with other tests", let's add a field that *enforces* this.
    Then it doesn't need to be commented; we have a variety of
    tests which are just "system inspection" (e.g. query rpmdb) and
    run just fine with `DynamicUser=yes` and hence *cannot* affect
    the system, and hence are inherently isolated from other concurrent
    tests.
    cgwalters committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    a21e0e4 View commit details
    Browse the repository at this point in the history