Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add a --prepare-only flag #3091

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

cgwalters
Copy link
Member

Part of #2685

I'm looking at replacing the guts of cosa build ostree with the new container-native rpm-ostree compose image. In order for that to work, we need two things:

Basically in combination with the above PR, this works now when invoked manually:

$ cosa build --prepare-only
$ sudo rpm-ostree compose image --cachedir=cache/buildimage  --layer-repo tmp/repo src/config/manifest.yaml oci:tmp/fcos.oci

jmarrero
jmarrero previously approved these changes Sep 12, 2022
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Part of coreos#2685

I'm looking at replacing the guts of `cosa build ostree` with the
new container-native `rpm-ostree compose image`.  In order
for that to work, we need two things:

- The committed overlays from `overlays/` - xref coreos/rpm-ostree#4005
- The rendered `image.json` which is also an overlay now

Basically in combination with the above PR, this works now when
invoked manually:

```
$ cosa build --prepare-only
$ sudo rpm-ostree compose image --cachedir=cache/buildimage  --layer-repo tmp/repo src/config/manifest.yaml oci:tmp/fcos.oci
```
@cgwalters
Copy link
Member Author

/override ci/prow/rhcos
CI flaked, this can't break rhcos really

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2022

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos

In response to this:

/override ci/prow/rhcos
CI flaked, this can't break rhcos really

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters cgwalters merged commit a99033d into coreos:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants