-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: choose latest y-stream versioning for rhcos upgrade #3266
Conversation
This needs to be backported all the way back to 4.10 since that was when this test was added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm honestly not fully following the logic here, but I'm assuming you tested this and it looks sane.
Added suggestions. Once this is backported to 4.10 we can remove the hack in coreos/coreos-ci-lib#136 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and added it verbatim. Thanks @jlebon!
Awesome, thanks for testing!
The cincinatti graph is used to determine the latest OCP release. It was assumed that only the latest node would have no upgrade path in the graph but that is not the case. When upgrades are blocked, there can be two nodes that no have upgrade path. We need to choose the newest one in the upgrade test.
/cherrypick rhcos-4.12 |
/cherrypick rhcos-4.11 |
/cherrypick rhcos-4.10 |
@jlebon: #3266 failed to apply on top of branch "rhcos-4.11":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jlebon: new pull request created: #3294 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jlebon: #3266 failed to apply on top of branch "rhcos-4.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This reverts commit 0642543. This test should be fixed now by coreos/coreos-assembler#3266 and backports.
This reverts commit 0642543. This test should be fixed now by coreos/coreos-assembler#3266 and backports.
The cincinatti graph is used to determine the latest OCP release. It was assumed that only the latest node would have no upgrade path in the graph but that is not the case. When upgrades are blocked, there can be two nodes that no have upgrade path. We need to choose the newest one in the upgrade test.