Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kola/testiso: test nmstate propagation as part of nm component #3397

Merged
merged 1 commit into from
May 23, 2023
Merged

kola/testiso: test nmstate propagation as part of nm component #3397

merged 1 commit into from
May 23, 2023

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Mar 22, 2023 •
edited

Add a check to nm tests that configures a Linux bridge via nmstate and confirms that a) the bridge is created and b) its configuration is propagated to the installed system via --copy-network.

@openshift-ci
Copy link

openshift-ci bot commented Mar 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bgilbert bgilbert mentioned this pull request Mar 22, 2023
Open
bgilbert
bgilbert commented Mar 22, 2023
View reviewed changes
Copy link
Contributor Author

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qinqon I drafted a test that uses nmstate to configure the live ISO, and then propagates the resulting config to the installed system with coreos-installer install --copy-network. It has a couple issues that could use some followup; see below.

mantle/cmd/kola/testiso.go Outdated Show resolved Hide resolved
mantle/cmd/kola/testiso.go Outdated Show resolved Hide resolved
cgwalters
cgwalters approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a sanity check here, but LGTM and thanks so much for adding tests for this type of stuff!

@bgilbert
kola/testiso: test nmstate propagation as part of "nm" component
9a98a23 
Add a check to "nm" tests that configures a Linux bridge via nmstate
and confirms that a) the bridge is created and b) its configuration is
propagated to the installed system via --copy-network.
@bgilbert bgilbert marked this pull request as ready for review May 23, 2023 03:46
@qinqon
Copy link

qinqon commented May 23, 2023

Thanks @cgwalters

@dustymabe
Copy link
Member

ci/prow/rhcos failed with:

 Resolving dependencies...done
error: Could not depsolve transaction; 2 problems detected:
 Problem 1: openssl-devel-1:3.0.7-18.el9.i686 from appstream  does not belong to a distupgrade repository
  - package kernel-rt-devel-5.14.0-316.el9.x86_64 from nfv requires openssl-devel, but none of the providers can be installed
  - package openssl-devel-1:3.0.7-18.el9.x86_64 from appstream requires openssl-libs(x86-64) = 1:3.0.7-18.el9, but none of the providers can be installed
  - cannot install both openssl-libs-1:3.0.7-18.el9.x86_64 from baseos and openssl-libs-1:3.0.7-17.el9.x86_64 from @System
  - conflicting requests

@bgilbert
Copy link
Contributor Author

/retest

@bgilbert bgilbert merged commit 5ebe967 into coreos:main May 23, 2023
@bgilbert bgilbert deleted the nmstate branch May 23, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

@qinqon qinqon qinqon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bgilbert @qinqon @dustymabe @cgwalters