-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/cmd-push-container-manifest: allow for missing architectures #3436
Conversation
hmm. I didn't touch any bash files and shellcheck CI job starts failing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me!
hmm. I didn't touch any bash files and shellcheck CI job starts failing?
I think this is from the new ShellCheck in f38. That GitHub Action uses the buildroot container which was updated after coreos/fedora-coreos-config#2376 merged. I'm addressing them in #3437.
In the case of kubevirt we are only building for a single architecture (right now) but we still want to use the `cosa push-container-manifest` workflow for pushing it to a registry. Let's allow for missing architectures if the user didn't explicitly specify a list of arches.
6215045
to
ea36e86
Compare
/override ci/prow/rhcos |
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If not specified the code will default to all built arches. We need this because we'll be adding kubevirt soon and it will only be built for x86_64. See also coreos/coreos-assembler#3436
If not specified the code will default to all built arches. We need this because we'll be adding kubevirt soon and it will only be built for x86_64. See also coreos/coreos-assembler#3436
If not specified the code will default to all built arches. We need this because we'll be adding kubevirt soon and it will only be built for x86_64. See also coreos/coreos-assembler#3436
In the case of kubevirt we are only building for a single architecture (right now) but we still want to use the
cosa push-container-manifest
workflow for pushing it to a registry. Let's allow for missing architectures if the user didn't explicitly specify a list of arches.