src/cmd-push-container-manifest: allow for missing architectures #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm. I didn't touch any bash files and shellcheck CI job starts failing? |
jlebon
previously approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Looks sane to me!
hmm. I didn't touch any bash files and shellcheck CI job starts failing?
I think this is from the new ShellCheck in f38. That GitHub Action uses the buildroot container which was updated after coreos/fedora-coreos-config#2376 merged. I'm addressing them in #3437.
In the case of kubevirt we are only building for a single architecture (right now) but we still want to use the `cosa push-container-manifest` workflow for pushing it to a registry. Let's allow for missing architectures if the user didn't explicitly specify a list of arches.
dustymabe
force-pushed
the
dusty-push-container-arches
branch
from
6215045
to
ea36e86
Compare
jlebon
approved these changes
Apr 19, 2023
|
/override ci/prow/rhcos |
|
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dustymabe
added a commit
to dustymabe/fedora-coreos-pipeline
that referenced
this pull request
Apr 19, 2023
If not specified the code will default to all built arches. We need this because we'll be adding kubevirt soon and it will only be built for x86_64. See also coreos/coreos-assembler#3436
dustymabe
added a commit
to dustymabe/fedora-coreos-pipeline
that referenced
this pull request
May 1, 2023
If not specified the code will default to all built arches. We need this because we'll be adding kubevirt soon and it will only be built for x86_64. See also coreos/coreos-assembler#3436
dustymabe
added a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
May 3, 2023
If not specified the code will default to all built arches. We need this because we'll be adding kubevirt soon and it will only be built for x86_64. See also coreos/coreos-assembler#3436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of kubevirt we are only building for a single architecture (right now) but we still want to use the
cosa push-container-manifestworkflow for pushing it to a registry. Let's allow for missing architectures if the user didn't explicitly specify a list of arches.