Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: support filter for kola list --json #3441

Merged
merged 1 commit into from
May 1, 2023

Conversation

HuijingHei
Copy link
Member

@HuijingHei HuijingHei commented Apr 27, 2023

kola list --distro rhcos --json does not work as without --json, this is to make the result consistent.
For example:

$ kola list -E /srv/rhcos9/src/config/ --distro=rhcos --json | jq -r '.[].Name' | grep binfmt
ext.config.shared.binfmt.qemu --> not expected, should not list here as it is desinged for fcos.

$ kola list -E /srv/rhcos9/src/config/ --distro=rhcos | grep binfmt
--> expected

`kola list --distro rhcos --json` does not work as without
`--json`, this is to make the result consistent.

For example:
```
$ kola list -E /srv/rhcos9/src/config/ --distro=rhcos --json | jq -r '.[].Name' | grep binfmt
ext.config.shared.binfmt.qemu --> not expected, should not list here as it is desinged for fcos.

$ kola list -E /srv/rhcos9/src/config/ --distro=rhcos | grep binfmt
--> expected
```
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cgwalters
Copy link
Member

/retest

@cgwalters cgwalters enabled auto-merge (rebase) May 1, 2023 13:16
@cgwalters cgwalters merged commit e04519d into coreos:main May 1, 2023
@HuijingHei HuijingHei deleted the json-distro-filter branch May 11, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants