cmd-sign: set priority level on Robosignatory fedmsg #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is work in Fedora infra[[1]] to use a Robosignatory queue that supports priority levels so that e.g. our artifact signing messages are handled before RPM signing of mass rebuilds. Start setting a priority level. Set it to 4 as proposed.[[2]] [1]: https://pagure.io/fedora-infrastructure/issue/10899 [2]: https://pagure.io/fedora-infrastructure/issue/10899#comment-854645
dustymabe
approved these changes
May 1, 2023
abompard
approved these changes
May 2, 2023
| ) | ||
| msg = message.Message(body=body, topic=topic) | ||
| if priority: | ||
| msg.priority = priority |
There was a problem hiding this comment.
Looks good to me! (that's the only part where my review might be relevant ;-) )
We should be unblocked on this now. |
|
Prow failure looks unrelated. /override ci/prow/rhcos |
|
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is work in Fedora infra[1] to use a Robosignatory queue that supports priority levels so that e.g. our artifact signing messages are handled before RPM signing of mass rebuilds.
Start setting a priority level. Set it to 4 as proposed.[2]