Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.13] kola: support tags for --allow-rerun-success #3447

Merged
merged 2 commits into from
May 3, 2023

Conversation

nikita-dubrovskii
Copy link
Contributor

New format is:

--allow-rerun-success tags=tag1[,tag2]

To allow all tests simply:

--allow-rerun-success tags=all

Co-authored-by: Dusty Mabe dusty@dustymabe.com

Issue: coreos/fedora-coreos-pipeline#842
(cherry picked from commit 864cece)

@nikita-dubrovskii nikita-dubrovskii changed the title kola: support tags for --allow-rerun-success [4.13] kola: support tags for --allow-rerun-success May 3, 2023
@dustymabe
Copy link
Member

for the shellcheck error maybe we need to cherry-pick 3c8651c ?

@openshift-ci
Copy link

openshift-ci bot commented May 3, 2023

@nikita-dubrovskii: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos 3996b71 link true /test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jlebon and others added 2 commits May 3, 2023 20:55
We're now using ShellCheck from f38 which detected new issues.

(cherry picked from commit 3c8651c)
New format is:
```
--allow-rerun-success tags=tag1[,tag2]
```

To allow all tests simply:
```
--allow-rerun-success tags=all
```

Co-authored-by: Dusty Mabe <dusty@dustymabe.com>

Issue: coreos/fedora-coreos-pipeline#842
(cherry picked from commit 864cece)
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe enabled auto-merge (rebase) May 3, 2023 19:00
@dustymabe dustymabe merged commit 859d5b1 into coreos:rhcos-4.13 May 3, 2023
2 checks passed
@nikita-dubrovskii nikita-dubrovskii deleted the 4.13 branch May 5, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants