Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/cmd-push-container-manifest: fix allowing for missing architectures #3452

Merged
merged 1 commit into from
May 4, 2023

Conversation

dustymabe
Copy link
Member

We need to use .get() here because if the key doesn't exist (which is what we are checking for) then we'll get a KeyError. Fixes a8bfe8f.

We need to use .get() here because if the key doesn't exist (which is
what we are checking for) then we'll get a KeyError. Fixes a8bfe8f.
Copy link

@joepvd joepvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dustymabe
Copy link
Member Author

since CI doesn't test this and it's a simple change I'll skip CI to unblock the release job in the pipelines.

@dustymabe dustymabe merged commit 3d95dbe into coreos:main May 4, 2023
2 checks passed
@dustymabe dustymabe deleted the dusty-kubevirt-fix branch May 4, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants