mantle/platform: allow systemctl is-system-running nonzero exit codes
#3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `CheckMachine()` call tolerates `systemctl is-system-running` returning e.g. `starting` and `initializing` in addition to the usual `running`. But by design, the command returns a nonzero exit code in those cases. Since we're explicitly checking the output string against the acceptable states, just ignore the command exit code so that we don't fail if the system is still starting. Prep for adding a test in which we expect the system to still be `starting`.
|
/retest |
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
May 26, 2023
In coreos/coreos-assembler#3487 we are changing the `sshChecker` in `CheckMachine()` to return earlier in the `starting` and `initializing` states. This means the kola test code might start to run earlier and we may need to wait longer here.
dustymabe
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
May 26, 2023
In coreos/coreos-assembler#3487 we are changing the `sshChecker` in `CheckMachine()` to return earlier in the `starting` and `initializing` states. This means the kola test code might start to run earlier and we may need to wait longer here.
|
/retest |
This was referenced May 27, 2023
|
/retest |
|
/cherrypick rhcos-4.13 |
|
@travier: new pull request created: #3497 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
travier
pushed a commit
to travier/fedora-coreos-config
that referenced
this pull request
Jun 1, 2023
In coreos/coreos-assembler#3487 we are changing the `sshChecker` in `CheckMachine()` to return earlier in the `starting` and `initializing` states. This means the kola test code might start to run earlier and we may need to wait longer here. (cherry picked from commit 3952477)
travier
pushed a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Jun 8, 2023
In coreos/coreos-assembler#3487 we are changing the `sshChecker` in `CheckMachine()` to return earlier in the `starting` and `initializing` states. This means the kola test code might start to run earlier and we may need to wait longer here. (cherry picked from commit 3952477)
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
In coreos/coreos-assembler#3487 we are changing the `sshChecker` in `CheckMachine()` to return earlier in the `starting` and `initializing` states. This means the kola test code might start to run earlier and we may need to wait longer here.
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
In coreos/coreos-assembler#3487 we are changing the `sshChecker` in `CheckMachine()` to return earlier in the `starting` and `initializing` states. This means the kola test code might start to run earlier and we may need to wait longer here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CheckMachine()call toleratessystemctl is-system-runningreturning e.g.startingandinitializingin addition to the usualrunning. But by design, the command returns a nonzero exit code in those cases.Since we're explicitly checking the output string against the acceptable states, just ignore the command exit code so that we don't fail if the system is still starting.
Prep for adding a test in which we expect the system to still be
starting.