-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mantle/kola/harness: allow success if all tests are denylisted #3489
Conversation
Skipping CI for Draft Pull Request. |
65d2baa
to
494a6cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but let's squash the commits down into a single commit if possible.
2798c96
to
4a33163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Once this merges we should be able to merge coreos/fedora-coreos-config#2446 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things I found later. Sorry.
Also, since we have to push up a new commit anyway maybe we can add some more context to the commit title/body:
mantle/kola/harness: allow success if all tests are denylisted
This will allow us to denylist certain categories of tests and not
have the pipeline fail. See [1] for a real world example of why this
is useful.
[1] https://github.com/coreos/fedora-coreos-config/commit/e983073e791073ae3e4fb5f4fc28f3d0e1e41ebb
a87f889
to
7869990
Compare
7869990
to
270bd12
Compare
/retest
…On Fri, Jun 2, 2023, at 00:16, openshift-ci[bot] wrote:
@Adam0Brien <https://github.com/Adam0Brien>: The following test *failed*, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:
Test name
Commit
Details
Required
Rerun command
ci/prow/rhcos
270bd12
link <https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/coreos_coreos-assembler/3489/pull-ci-coreos-coreos-assembler-main-rhcos/1664472418149732352>
true
`/test rhcos`
Full PR test history <https://prow.ci.openshift.org/pr-history?org=coreos&repo=coreos-assembler&pr=3489>. Your PR dashboard <https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:Adam0Brien>.
Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>.
—
Reply to this email directly, view it on GitHub <#3489 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCR63T43SWPZF5JWYBDP4LXJFSIPANCNFSM6AAAAAAYSXLETM>.
You are receiving this because you commented.Message ID: ***@***.***>
|
270bd12
to
28ef3e5
Compare
/retest |
9f9f657
to
dba6831
Compare
This will allow us to denylist certain categories of tests and not have the pipeline fail. See [1] for a real world example of why this is useful. [1] coreos/fedora-coreos-config@e983073
dba6831
to
4932505
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
1 similar comment
/retest |
Fix : #3464
This PR introduces a new check in coreos-assembler that notifies users when running only denylisted tests
eg output:
And an additional feature that ensures your running a test with a valid name