[rhcos-4.13] koji-upload: Change artifact used to store the rpm list #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- To store the rpm list in Brew we need to link it to an artifact, let's change it from qemu (1 GB) to the commitmeta.json (60 KB) due the size. - The rpm list is also generated from commitmeta.json, what make sense to have it instead. Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit dd7315e)
dustymabe
approved these changes
May 30, 2023
|
/retest-required |
|
Out of curiosity what's the problem with the size in this context? Is it that the qemu image is required to upload before we can store RPM metadata? |
We are not required to upload the qemu image basically, only the rpm info (metadata), we would need to download the qemu image from S3 and download to brew, we need an artifact in brew to link the rpm list. We decided to add brew as part of the release job, in the past brew had connection issues to upload the artifacts, 1G is not that much, but if we can avoid that, would be great ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commitmeta.json (60 KB) due the size.
Signed-off-by: Renata Ravanelli rravanel@redhat.com
(cherry picked from commit dd7315e)