mantle/kola: fix scope on denylisted variable #3512
Conversation
This variable should have been scoped inside the loop. Outside the loop the `true` value can carry forward and get applied to tests that actually aren't denylisted. Fixes ac9bd49.
| r := make(map[string]*register.Test) | ||
| for name, t := range tests { | ||
| // Drop anything which is denylisted directly or by pattern | ||
| denylisted := false |
There was a problem hiding this comment.
Good catch! The original code was running var denylisted bool each loop iteration. I missed that in the original PR.
There was a problem hiding this comment.
Yep. Copy and paste got me in trouble. I didn't pay enough attention to detail and my local tests looked good, but they weren't comprehensive enough.
|
@dustymabe: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
prow timed out at 4h - ignoring. |
This variable should have been scoped inside the loop. Outside the loop the
truevalue can carry forward and get applied to tests that actually aren't denylisted.Fixes ac9bd49.