kola/harness.go: add info to recently expired snooze

[c4rt0]

Fix: #3462

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[cverna]

From a quick look, you probably want to squash your commits :-)

[c4rt0]

From a quick look, you probably want to squash your commits :-)

Now that was a quick response, thanks :)

[travier]

I added a super important review comment ™️

[c4rt0]

/retest

[dustymabe]

This currently doesn't tell me much information about which test was unsnoozed recently:

kola -p qemu run fcos.internet --output-dir tmp/kola
⏰ Snooze expired "Jun 20 2023":
⚠️  Skipping kola test pattern "podman.workflow":
  👉 https://github.com/coreos/coreos-assembler/pull/1478
=== RUN   fcos.internet
=== RUN   fcos.internet/PodmanEcho
=== RUN   fcos.internet/PodmanWgetHead
--- PASS: fcos.internet (27.23s)
    --- PASS: fcos.internet/PodmanEcho (1.60s)
    --- PASS: fcos.internet/PodmanWgetHead (0.29s)
PASS, output in tmp/kola
+ rc=0
+ set +x

[dustymabe]

I think this information would be most useful if it was presented to the user along with the failure message.. i.e. The user is more likely to skip over the "header" at the top and just look at the failure message itself and we'll end up in the same situation we are in today where someone goes down the road of investigating a test failure when the problem is already well known.

If we could get something like what was described in #3462 (comment) that would be more helpful (though I admit this would be harder to achieve):

[2023-05-09T02:57:34.826Z] --- FAIL: ext.config.shared.networking.nmstate.state (27.96s) snooze expired 2023-05-08

I'd be happy to modify that to include an emoji :)

What you have in this PR already is useful too, though. So we could maybe print the information at the top like you are doing now AND include it along with a failure.

WDYT?

[c4rt0]

This currently doesn't tell me much information about which test was unsnoozed recently:

kola -p qemu run fcos.internet --output-dir tmp/kola
⏰ Snooze expired "Jun 20 2023":
⚠️  Skipping kola test pattern "podman.workflow":
  👉 https://github.com/coreos/coreos-assembler/pull/1478
=== RUN   fcos.internet
=== RUN   fcos.internet/PodmanEcho
=== RUN   fcos.internet/PodmanWgetHead
--- PASS: fcos.internet (27.23s)
    --- PASS: fcos.internet/PodmanEcho (1.60s)
    --- PASS: fcos.internet/PodmanWgetHead (0.29s)
PASS, output in tmp/kola
+ rc=0
+ set +x

Agreed.

I think this information would be most useful if it was presented to the user along with the failure message.. i.e. The user is more likely to skip over the "header" at the top and just look at the failure message itself and we'll end up in the same situation we are in today where someone goes down the road of investigating a test failure when the problem is already well known.

If we could get something like what was described in #3462 (comment) that would be more helpful (though I admit this would be harder to achieve):

[2023-05-09T02:57:34.826Z] --- FAIL: ext.config.shared.networking.nmstate.state (27.96s) snooze expired 2023-05-08

I'd be happy to modify that to include an emoji :)

What you have in this PR already is useful too, though. So we could maybe print the information at the top like you are doing now AND include it along with a failure.

WDYT?

I will try now to include it along with the failure, as it was originally stated in the linked issue.

[ravanelli]

Should that be snoozeFormat due that the revert change you did?

[c4rt0]

/do-not-merge

[c4rt0]

/ok-to-test

[c4rt0]

/retest

[c4rt0]

Just to summarize the work on this issue I would like to extend my gratitude to everyone for their patience. I was stuck in a loophole trying to re-work what was already done some months ago. Since I had no previous exposure to Go I was taking time in finding a way around it. First I was focusing on the testiso.go where I spotted an opportunity to modify 'FAIL' result prompt. Without an understanding of the correct usage of functions/methods in Go I was ignoring the bool return type for a while in the printResult function. After that lesson was learned I attempted to extract data from the DenyListObj not remembering that first yaml object must be parsed in order to extract the data. As a result, I am now focusing on the ParseDenyListYaml function which already does everything I needed in order to address considered here issue.

[c4rt0]

Due to recent developments, this is no longer required.