mantle/platform: Simplify failed unit detection & Only check that the VARIANT_ID is 'coreos' #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not special case the failed unit detection logic for each distributions. If we need to ignore some unit failures in the future for some distributions, we should add support for this using a proper kola-denylist entry instead so that we can track it properly. This removes the special case for RHCOS which is no longer relevant as we've moved to RHEL 9. Also remove the test that are not relevant anymore. This mostly reverts: coreos#2261
We now have Fedora CoreOS, CentOS Stream CoreOS and RHEL CoreOS and they all set 'coreos' as VARIANT_ID. We don't need more complex checks here.
|
/retest |
1 similar comment
|
/retest |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mantle/platform: Simplify failed unit detection
Do not special case the failed unit detection logic for each
distributions.
If we need to ignore some unit failures in the future for some
distributions, we should add support for this using a proper
kola-denylist entry instead so that we can track it properly.
This removes the special case for RHCOS which is no longer relevant as
we've moved to RHEL 9.
Also remove the test that are not relevant anymore.
This mostly reverts: #2261
mantle/platform: Only check that the VARIANT_ID is 'coreos'
We now have Fedora CoreOS, CentOS Stream CoreOS and RHEL CoreOS and they
all set 'coreos' as VARIANT_ID.
We don't need more complex checks here.