Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to f39 #3653

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Update to f39 #3653

merged 5 commits into from
Nov 16, 2023

Conversation

cgwalters
Copy link
Member

@cgwalters cgwalters commented Nov 9, 2023

Update to f39

Today the ostree CI relies on the buildroot container, cosa and FCOS
all being on the same major.


build: Unfreeze grub2

We will just have to stop testing ppc64le with PXE boot.

HOWEVER: An important thing we could try to do going forward
is again do a build of coreos-assembler using RHEL 9 (or CentOS Stream 9).
We're not actually that far away from this last I tried, particularly
using EPEL content.


@cgwalters
Copy link
Member Author

Ah right yes, running headfirst into the grub2 thing for ppc...

Today the ostree CI relies on the buildroot container, cosa and FCOS
all being on the same major.
We will just have to stop testing ppc64le with PXE boot.

HOWEVER: An important thing we could try to do going forward
is again do a build of coreos-assembler using RHEL 9 (or CentOS Stream 9).
We're not actually that far away from this last I tried, particularly
using EPEL content.
It seems like jsonschema in Python 3.12 (in Fedora 39) changed some
implementation details to now use a data structure that doesn't support
deep copying:

    TypeError: cannot pickle 'rpds.HashTrieMap' object

Instead of doing a deep copy, just create a new object from scratch with
the same inputs. The `w` variable might've been for that; it's currently
unused and is an exact copy of `m`.
@jlebon
Copy link
Member

jlebon commented Nov 15, 2023

OK cool, we got green CI here now!
I'm going to tag a release and then we can get this in.

Edit: Ahh, Prow CI hasn't run yet since it was in draft mode. Definitely let's make sure RHCOS is happy first.

@jlebon
Copy link
Member

jlebon commented Nov 15, 2023

Prow needs openshift/release#45710 to pass.

Dockerfile Outdated Show resolved Hide resolved
jlebon added a commit to jlebon/release that referenced this pull request Nov 15, 2023
Matches coreos/coreos-assembler#3653.

While we're here, use the Quay.io image instead since that's the future.
The Fedora project is moving its images in Quay.io as being the official
ones. Let's use it instead.
openshift-merge-bot bot pushed a commit to openshift/release that referenced this pull request Nov 15, 2023
Matches coreos/coreos-assembler#3653.

While we're here, use the Quay.io image instead since that's the future.
@jlebon
Copy link
Member

jlebon commented Nov 15, 2023

/retest

@jlebon
Copy link
Member

jlebon commented Nov 15, 2023

Nov 15 18:34:04.296872 systemd-fsck@dev-disk-by\x2duuid-5af1a9ae\x2db471\x2d4edb\x2dac2e\x2db6c26bf57aea.service[1251]: /dev/nvme0n1p3 has unsupported feature(s): FEATURE_C12
Nov 15 18:34:04.296872 systemd-fsck@dev-disk-by\x2duuid-5af1a9ae\x2db471\x2d4edb\x2dac2e\x2db6c26bf57aea.service[1251]: e2fsck: Get a newer version of e2fsck!
Nov 15 18:34:04.333079 systemd-fsck@dev-disk-by\x2duuid-5af1a9ae\x2db471\x2d4edb\x2dac2e\x2db6c26bf57aea.service[1251]: boot: ********** WARNING: Filesystem still has errors **********
Nov 15 18:34:04.301141 systemd-fsck@dev-disk-by\x2duuid-5af1a9ae\x2db471\x2d4edb\x2dac2e\x2db6c26bf57aea.service[1243]: fsck failed with exit status 12.

Ohh fun. Looks like e2fsprogs 1.47 added a new feature that e2fsck in el9 can't handle.

The fix for this of course is to use the mkfs.* from the target system and not cosa, but that's a larger refactor. Short-term... I guess we add another knob in image.yaml?

Hmm, let me see if I can do some kind of feature detection.

Fedora 39 has a newer e2fsprogs whose `mkfs.ext4` now turns on a new
`orphan_file` feature by default. This feature is not supported by the
`e2fsck` currently in RHEL 9.

As mentioned in the comment, ideally we'd use the `mkfs.*` tools
from the target system and not from cosa. But for now, just do some
version testing to know when to opt out to avoid having to add another
`image.yaml` knob for it.

See: coreos#3653 (comment)
@jlebon
Copy link
Member

jlebon commented Nov 16, 2023

OK cool, CI is happy now!
Since I've added non-trivial commits, I'll let someone else do the review.
Don't merge it yet though. I'd like to cut a release and add a tag in Quay.io on the current image just in case.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

I guess maybe let's try to get this in soon so I can rebase #3654

@jlebon
Copy link
Member

jlebon commented Nov 16, 2023

Release done and Quay.io tag added!

@jlebon jlebon merged commit 1c280e7 into coreos:main Nov 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants