Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mantle/test: Modify timeout to resolve coreos.unique.boot.failure issue #3680

Merged
merged 1 commit into from
Dec 8, 2023
Merged

mantle/test: Modify timeout to resolve coreos.unique.boot.failure issue #3680

merged 1 commit into from
Dec 8, 2023
+1 −1

Conversation

c4rt0
Copy link
Member

@c4rt0 c4rt0 commented Dec 5, 2023 •
edited

Fix: #3669

@c4rt0
Copy link
Member Author

c4rt0 commented Dec 6, 2023

Please correct me if I'm wrong, but I have a strong feeling this trivial change hits the root of the problem.

@jlebon
Copy link
Member

jlebon commented Dec 6, 2023

Hmm, looking at #3670, it failed in 37 seconds, which is within the previous timeout. Were you able to reproduce that failure in RHCOS locally?

For #3669 indeed, it looks like we're timing out.

@jlebon
Copy link
Member

jlebon commented Dec 6, 2023

I'd be fine to get this in if we drop the #3670 reference.

@c4rt0
Copy link
Member Author

c4rt0 commented Dec 8, 2023

I'd be fine to get this in if we drop the #3670 reference.

Reference removed.
Thanks!

jbtrystram
jbtrystram approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c4rt0 c4rt0 merged commit 4636b1a into coreos:main Dec 8, 2023
5 checks passed
@c4rt0 c4rt0 deleted the kola_bootfsfailure branch December 8, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbtrystram jbtrystram jbtrystram approved these changes

@jlebon jlebon Awaiting requested review from jlebon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coreos.unique.boot.failure kola test fails on aarch64
3 participants
@c4rt0 @jlebon @jbtrystram