Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osbuild: don't compress in the qemu stage for now #3717

Merged
merged 1 commit into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ patch_osbuild() {
/usr/lib/coreos-assembler/0001-stages-zipl.inst-improve-kernel-initrd-path-resoluti.patch \
/usr/lib/coreos-assembler/0002-stages-zipl.inst-support-appending-kernel-options.patch \
/usr/lib/coreos-assembler/0001-stages-copy-allow-copying-from-the-tree.patch \
/usr/lib/coreos-assembler/0001-stages-qemu-don-t-use-internal-compression-for-now.patch \
| patch -d /usr/lib/osbuild -p1

# And then move the files back; supermin appliance creation will need it back
Expand Down
30 changes: 30 additions & 0 deletions src/0001-stages-qemu-don-t-use-internal-compression-for-now.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
From 372df8e1adb3c76f092ed47a45ee8637a247c786 Mon Sep 17 00:00:00 2001
From: Dusty Mabe <dusty@dustymabe.com>
Date: Mon, 5 Feb 2024 17:38:41 -0500
Subject: [PATCH] stages(qemu): don't use internal compression for now

Until this is an option in the stage let's disable it for now
https://github.com/coreos/fedora-coreos-tracker/issues/1653#issuecomment-1928342241
---
stages/org.osbuild.qemu | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/stages/org.osbuild.qemu b/stages/org.osbuild.qemu
index 98a04f00..07172b3d 100755
--- a/stages/org.osbuild.qemu
+++ b/stages/org.osbuild.qemu
@@ -140,7 +140,10 @@ SCHEMA_2 = r"""


def qcow2_arguments(options):
- argv = ["-c"]
+ # No internal compression in CoreOS for now.
+ # https://github.com/coreos/fedora-coreos-tracker/issues/1653#issuecomment-1928342241
+ # argv = ["-c"]
+ argv = []
compat = options.get("compat")

if compat:
--
2.43.0

Loading