Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd-compress: use level 10 for zstd compression #3721

Merged
merged 1 commit into from
May 27, 2024

Conversation

dustymabe
Copy link
Member

Based on the discussion in coreos/fedora-coreos-tracker#1660 level 10 seems to give us a good speedup versus size tradeoff.

Based on the discussion in coreos/fedora-coreos-tracker#1660
level 10 seems to give us a good speedup versus size tradeoff.
@dustymabe dustymabe enabled auto-merge (rebase) February 7, 2024 15:48
@jlebon
Copy link
Member

jlebon commented May 9, 2024

Maybe let's flesh out the plan in coreos/fedora-coreos-tracker#1660 first?

@dustymabe
Copy link
Member Author

Maybe let's flesh out the plan in coreos/fedora-coreos-tracker#1660 first?

I think we could merge this without fleshing out the plan, since this doesn't really change the default to zstd, it just changes the default for zstd.

but ideally, yeah we'd figure out what we want to do in general. thoughts on how to make progress? should I retag the tracker issue with meeting? maybe we are still at this point: coreos/fedora-coreos-tracker#1660 (comment)

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

but ideally, yeah we'd figure out what we want to do in general. thoughts on how to make progress? should I retag the tracker issue with meeting? maybe we are still at this point: coreos/fedora-coreos-tracker#1660 (comment)

Sure, we can retag it.

@dustymabe dustymabe merged commit 28a26d6 into coreos:main May 27, 2024
5 checks passed
@dustymabe dustymabe deleted the dusty-zstd-compress branch May 27, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants