cmdlib: use BTRFS for the cache2.qcow2 #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We switched to ext4 to get away from using reflinks (see [1]) but the problem was actually specific to XFS. It's now been fixed upstream in [2], but we need to wait for it to get back backported to stable branches. Let's switch to BTRFS for now so we can still get the space savings of reflinks, while avoiding the reflink bug in XFS. [1] coreos#3728 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4b2f459d86252619448455013f581836c8b1b7da
jlebon
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switched to ext4 to get away from using reflinks (see [1]) but the problem was actually specific to XFS. It's now been fixed upstream in [2], but we need to wait for it to get back backported to stable branches. Let's switch to BTRFS for now so we can still get the space savings of reflinks, while avoiding the reflink bug in XFS.
[1] #3728
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4b2f459d86252619448455013f581836c8b1b7da