add iscsi+multipath test; add some improvements to test strategy #3789
Commits on May 7, 2024
-
mantle/platform/qemu: Adjust dependencies on journal-stream unit
The unit kept getting killed when entering emergency.target, which isn't very useful since some of the messages that hadn't been flushed yet were the ones that revealed the root cause of the failure. Let's set up the ordering/deps such that it doesn't get taken down when entering emergency.target. Also add a sleep 1 in the Destroy to allow for some remaining messages to get flushed.
-
mantle/platform/qemu: drop json formatting from journal output
In my experience the value of this has been little to none. It mostly just forces us to filter this output through jq -r .MESSAGE Let's make it just output text like the non-testiso journal.txt files are today.
-
mantle/kola/testiso: fix firmware entries for multi-arch iscsi tests
There's no bios on aarch64, ppc64le or s390x.
-
mantle/kola: drop unnecessary kargs for iscsi tests
The ip=ibft seems to only dictate what interface to use when bringing up networking, but isn't important if you are using DHCP IIUC. The rd.iscsi.initiator also isn't important here. It appears to work without it.
-
mantle/kola/testiso: switch one iscsi test to use uefi
This will help get more test coverage.
-
mantle/kola: make options to iscsiadm long options
Makes it a little bit easier for the reader to understand what the options are doing without having to study the iscsiadm man page.
-
mantle/kola: use random uuid for ipxe initiator-iqn
We can use a random value here because we don't have ACL's enabled for this test. Let's just make it a random UUID to make it more clear the value isn't significant.
-
mantle/kola: login from discovery mode
This has the same effect, just uses one fewer command!
-
mantle/kola: use OnFailureJobMode=isolate for iscsi test units
When we go to emergency.target it's standard to use OnFailureJobMode=isolate.
-
mantle/kola: simplify naming of iscsi targets
The format doesn't need the extra pieces, which might be confused as important. Let's use the simplest possible name here.
-
mantle/kola/testiso: add iscsi test for multipath on top of iscsi
Here we modify the iscsi setup to define two ports `:0` and `:1` that both expose the same underlying block device, which means that multipath can be set up on top of those two paths. We then add a new test that provides `root=/dev/disk/by-label/dm-mpath-root` and `rd.multipath=default` to the kernel command line to perform the test. Note that this modifies the targetd setup and the iPXE config for all of the tests, but they still work fine, just accessing `:0` and leaving `:1` alone.
