[rhcos-4.16] add more iscsi test cases #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test simply changes the kargs from `rd.iscsi.firmware=1` to `netroot=iscsi...` at the coreos-installer step. This will ensure we support no-ibft installations. Partial fix for coreos/fedora-coreos-tracker#1651 (cherry picked from commit d0fc725)
The unit kept getting killed when entering emergency.target, which isn't very useful since some of the messages that hadn't been flushed yet were the ones that revealed the root cause of the failure. Let's set up the ordering/deps such that it doesn't get taken down when entering emergency.target. Also add a sleep 1 in the Destroy to allow for some remaining messages to get flushed. (cherry picked from commit 862c4a0)
In my experience the value of this has been little to none. It mostly just forces us to filter this output through jq -r .MESSAGE Let's make it just output text like the non-testiso journal.txt files are today. (cherry picked from commit 7b07ffe)
There's no bios on aarch64, ppc64le or s390x. (cherry picked from commit 174eb8a)
The ip=ibft seems to only dictate what interface to use when bringing up networking, but isn't important if you are using DHCP IIUC. The rd.iscsi.initiator also isn't important here. It appears to work without it. (cherry picked from commit 666b1eb)
This will help get more test coverage. (cherry picked from commit 31c2f01)
Makes it a little bit easier for the reader to understand what the options are doing without having to study the iscsiadm man page. (cherry picked from commit 83f7695)
We can use a random value here because we don't have ACL's enabled for this test. Let's just make it a random UUID to make it more clear the value isn't significant. (cherry picked from commit cb94590)
This has the same effect, just uses one fewer command! (cherry picked from commit b305448)
When we go to emergency.target it's standard to use OnFailureJobMode=isolate. (cherry picked from commit 713c94f)
The format doesn't need the extra pieces, which might be confused as important. Let's use the simplest possible name here. (cherry picked from commit 93d4b0b)
(cherry picked from commit 313420e)
Here we modify the iscsi setup to define two ports `:0` and `:1` that both expose the same underlying block device, which means that multipath can be set up on top of those two paths. We then add a new test that provides `root=/dev/disk/by-label/dm-mpath-root` and `rd.multipath=default` to the kernel command line to perform the test. Note that this modifies the targetd setup and the iPXE config for all of the tests, but they still work fine, just accessing `:0` and leaving `:1` alone. (cherry picked from commit c317213)
jlebon
approved these changes
May 7, 2024
jlebon
requested changes
May 7, 2024
fixed! |
jlebon
approved these changes
May 7, 2024
|
@dustymabe: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports for: