Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testiso: add rw karg to iSCSI multipath test #3797

Merged
merged 1 commit into from
May 8, 2024
Merged

testiso: add rw karg to iSCSI multipath test #3797

merged 1 commit into from
May 8, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented May 8, 2024

This is required by ostree.

This sometimes worked I think because ignition-remount-sysroot.service has no ordering against ostree-prepare-root.service and so they'd race. But really, we shouldn't rely on that Ignition unit.

See also: #3789 (comment)

@jlebon
testiso: add rw karg to iSCSI multipath test
e2c8b89 
This is required by ostree.

This sometimes worked I think because `ignition-remount-sysroot.service`
has no ordering against `ostree-prepare-root.service` and so they'd
race. But really, we shouldn't rely on that Ignition unit.

See also: coreos#3789 (comment)
dustymabe
dustymabe approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe enabled auto-merge (rebase) May 8, 2024 17:44
@dustymabe dustymabe mentioned this pull request May 8, 2024
Merged
@jlebon
Copy link
Member Author

jlebon commented May 8, 2024

Hmm, Prow failing on ext.config.systemd.journal-compat. I saw that on another PR as well. We'll have to debug that.

But let's get this in to unbreak upstream CIs that run kola testiso.

/override ci/prow/rhcos

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 8, 2024

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos

In response to this:

Hmm, Prow failing on ext.config.systemd.journal-compat. I saw that on another PR as well. We'll have to debug that.

But let's get this in to unbreak upstream CIs that run kola testiso.

/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dustymabe dustymabe merged commit 109cae9 into coreos:main May 8, 2024
5 checks passed
@jlebon
Copy link
Member Author

jlebon commented May 8, 2024

Hmm, Prow failing on ext.config.systemd.journal-compat. I saw that on another PR as well. We'll have to debug that.

Filed openshift/os#1505 since it doesn't look like a flake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlebon @dustymabe