-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build.sh: remove edk2-ovmf version freeze #3818
Conversation
2e08403
to
61a72b7
Compare
This is totally fine, though a more idiomatic way to do this would be to use Also, can you make sure that your commit messages wrap at some reasonable column (usually 72)? |
61a72b7
to
740f3cc
Compare
Thanks! I updated the commit to be a revert. I've left the default revert message. Let me know if it's okay. |
85390fc
to
0b5f3fa
Compare
This reverts commit f056c0e. The package has been fixed and update so we are able to revert this to start to use the latest version. Closes: coreos#3815 Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2290441
0b5f3fa
to
98889cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this!
Prow will likely fail on openshift/os#1523 (comment); we can override it if so. |
/override ci/prow/rhcos |
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We temporarily froze updates to that version due to issues with the FCOS PXE 4K UEFI tests. You can check it here: #3816.
Now that we had a update to fix it, we can switch back to the latest version.