Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhcos-4.16] osbuild: make building with OSBuild the default #3820

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jun 12, 2024

Now all of our streams are ready to be switched to OSBuild and RHCOS
latest streams are also switched over. Let's make it the default so
we don't have to set COSA_USE_OSBUILD=1 any longer. This also has
the side effect of making all CI run with OSBUild now too.

(cherry picked from commit 4d94dc3)

4.16 is already being built with COSA_USE_OSBUILD today.
Cherry-picking this will allow us to clean up our pipecfg.

dustymabe and others added 2 commits June 12, 2024 16:20
Now all of our streams are ready to be switched to OSBuild and RHCOS
latest streams are also switched over. Let's make it the default so
we don't have to set COSA_USE_OSBUILD=1 any longer. This also has
the side effect of making all CI run with OSBUild now too.

(cherry picked from commit 4d94dc3)

4.16 is already being built with `COSA_USE_OSBUILD` today.
Cherry-picking this will allow us to clean up our pipecfg.
This reverts commit 0b659af.

That was meant to be a temporary measure but lingered for a while. As
mentioned there, ideally, we'd build both, but if we only build one, let
it be RHCOS.

(cherry picked from commit 06ae3e1)

That should fix CI.
Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit f85cc74 into coreos:rhcos-4.16 Jun 13, 2024
4 of 5 checks passed
@jlebon jlebon deleted the pr/rhcos-4.16 branch June 13, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants