Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd-sign: add --verify-only #3821

Merged
merged 1 commit into from
Jun 17, 2024
Merged

cmd-sign: add --verify-only #3821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
35 changes: 20 additions & 15 deletions src/cmd-sign
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ def parse_args():
robosig.add_argument("--gpgkeypath", help="path to directory containing "
"public keys to use for signature verification",
default="/etc/pki/rpm-gpg")
robosig.add_argument("--verify-only", action='store_true',
help="verify only that the sigs are valid and make public")
robosig.set_defaults(func=cmd_robosignatory)

return parser.parse_args()
Expand Down Expand Up @@ -98,6 +100,8 @@ def cmd_robosignatory(args):

# these two are different enough that they deserve separate handlers
if args.ostree:
if args.verify_only:
raise Exception("Cannot use --verify-only with --ostree")
robosign_ostree(args, s3, build, gpgkey)
else:
assert args.images
Expand Down Expand Up @@ -215,21 +219,22 @@ def robosign_images(args, s3, build, gpgkey):
'checksum': f'sha256:{img["sha256"]}'
} for img in build['images'].values()]

response = send_request_and_wait_for_response(
request_type='artifacts-sign',
config=args.fedmsg_conf,
request_timeout=ROBOSIGNATORY_REQUEST_TIMEOUT_SEC,
priority=ROBOSIGNATORY_MESSAGE_PRIORITY,
environment=fedenv,
body={
'build_id': args.build,
'basearch': args.arch,
'artifacts': artifacts,
**args.extra_keys
}
)

validate_response(response)
if not args.verify_only:
response = send_request_and_wait_for_response(
request_type='artifacts-sign',
config=args.fedmsg_conf,
request_timeout=ROBOSIGNATORY_REQUEST_TIMEOUT_SEC,
priority=ROBOSIGNATORY_MESSAGE_PRIORITY,
environment=fedenv,
body={
'build_id': args.build,
'basearch': args.arch,
'artifacts': artifacts,
**args.extra_keys
}
)

validate_response(response)

# download sigs and verify (use /tmp to avoid gpg hitting ENAMETOOLONG)
with tempfile.TemporaryDirectory(prefix="cosa-sign-") as d:
Expand Down