cmd/prune-contaiers: add a GC script for containers images #3826
Conversation
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. If no duration is specified, no image will be pruned. See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
There was a problem hiding this comment.
I'm surprised by the choice of bash. I think any new command with non-trivial logic should be written in one of the other two languages in this repo (Python or Go).
There was a problem hiding this comment.
The comments below are only about overall logic and not bash-specific things.
|
|
||
| for tag in $tags; do | ||
|
|
||
| # ignore the named moving tags ("stable", "next" etc..) |
There was a problem hiding this comment.
I think I would generalize this as "ignore all tags that don't match the build ID format".
| # value | ||
| tag_age=$(( today - $(date -d "${build_date}" +%s) )) | ||
|
|
||
| # test for production streams. Production stream id are 1, 2 and 3 |
There was a problem hiding this comment.
I think it'd be nice to follow a model closer to cosa cloud-prune where the policy is encoded in a separate YAML file that this command reads in. That would allow us to keep that file in e.g. fedora-coreos-pipeline and possibly down the the line have a similar file for RHCOS.
| # test for production streams. Production stream id are 1, 2 and 3 | ||
| if [[ $stream -eq 1 || $stream -eq 2 || $stream -eq 3 ]]; then | ||
| if [[ $tag_age -gt "$prod_age_seconds" ]]; then | ||
| echo "Production tag ${tag} is older than ${PROD_AGE}, pruning." |
There was a problem hiding this comment.
This isn't considering barrier releases.
There was a problem hiding this comment.
I guess i would have to pull the builds.json for each stream to see if the release is a barrier..
is a LABEL attached to the container to indicate they are barrier releases ? That would be neat
There was a problem hiding this comment.
The source of truth for barriers is in https://github.com/coreos/fedora-coreos-streams/tree/main/updates. You can download from there, or from the S3-uploaded version (e.g. https://builds.coreos.fedoraproject.org/updates/testing.json).
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure.
If no duration is specified, no image will be pruned.
See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995