-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add a remote kdump test #3829
Conversation
Skipping CI for Draft Pull Request. |
There is one to say that the VM is expected to crash: https://github.com/coreos/fedora-coreos-config/blob/testing-devel/tests/kola/kdump/crash/test.sh#L7
You can likely find the corresponding option in the code to set that for this test. |
yep that was it. Thanks @travier ! |
980ece7
to
3efbf2a
Compare
I think this is now ready for review The test now pass :
|
the RHCOS test fails on the SSH command to crash the kernel.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A string of nits, but looks good overall!
3051876
to
6136cc8
Compare
This test setups two machines to test if kdump successfully exports vmcore to a SSH destination. This sets a fairly large timeout for kdump to become active as generating the initramfs can be long on slower systems. Fixes coreos/fedora-coreos-tracker#1753
6136cc8
to
065b570
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM!
This test was recently added in coreos/coreos-assembler#3829 but hit the same issue as `ext.kdump.crash`. This should be fixed in kexec-tools-2.0.28-12.fc40, so extending the snooze for 5 days only as it should hit stable soon.
This test was recently added in coreos/coreos-assembler#3829 but hit the same issue as `ext.kdump.crash`. This should be fixed in kexec-tools-2.0.28-12.fc40, so extending the snooze for 5 days only as it should hit stable soon.
This test setups two machines to test if kdump successfully exports vmcore to a SSH destination.
Fixes coreos/fedora-coreos-tracker#1753
This is not fully functional yet but ready for review I think.
The test setup works ( i can see the logs created on the remote machine) but kola fails the test somehow :
is there some flag to say the machine is expected to reboot ?