Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support building hetzner disk images #4023

Merged
merged 2 commits into from
Feb 14, 2025
Merged

support building hetzner disk images #4023

merged 2 commits into from
Feb 14, 2025

Conversation

dustymabe
Copy link
Member

@dustymabe
Copy link
Member Author

to test this:

cosa build ostree && cosa osbuild hetzner && cosa compress

Then feed to hcloud-image-uploader tool

@dustymabe dustymabe mentioned this pull request Feb 12, 2025
Open
44 tasks
@travier
Copy link
Member

travier commented Feb 13, 2025 •
edited
Loading

Should we compress it with bzip2? https://github.com/coreos/fedora-coreos-docs/pull/654/files#diff-287be04ab821d60466b7c687e69525df87346705b47cac1653e2ea104fa28d74R110

Is that what the cosa compress command does?

Edit: It compresses using xz and this is supported by https://github.com/apricote/hcloud-upload-image (https://github.com/apricote/hcloud-upload-image/blob/b328867f6b9b965dcd581cb6f6907dae364faa7a/cmd/upload.go#L98)

travier
travier previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've manually tested that an image built using this code and uploaded to Hetzner works.

@travier
Copy link
Member

travier commented Feb 13, 2025

Looks like this needs a schema sync/update

@dustymabe dustymabe force-pushed the dusty-hetzner branch 2 times, most recently from 7087148 to 66f7aa3 Compare February 13, 2025 19:49
@dustymabe
support building hetzner disk images
6fae40c
@dustymabe
osbuild-manifests: update comment at the top of the ipp.yaml files
9720af2 
We are getting closer to when these will be used for our production
streams so let's update the comments so they don't become out of date.
@dustymabe dustymabe enabled auto-merge (rebase) February 14, 2025 14:04
@dustymabe
Copy link
Member Author

CI failure is unrelated to this change

/override ci/prow/rhcos

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 14, 2025

@dustymabe: Overrode contexts on behalf of dustymabe: ci/prow/rhcos

In response to this:

CI failure is unrelated to this change

/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dustymabe dustymabe merged commit a27b8a0 into coreos:main Feb 14, 2025
5 checks passed
@dustymabe dustymabe deleted the dusty-hetzner branch February 14, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dustymabe @travier