-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildextend: create initramfs and kernel artifacts #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But those projects currently only know how to parse traditional Pungi/lorax/Anaconda generated IOW you can't just It feels like this is more about "convenience of retrieving" the kernel/initrd. They're in that ISO (and for that matter the qemu/etc images)...but extracting them from the I'm fine with this patch as is, but I wonder whether it'd be better to e.g. Also...today we add the version number into our VM images - I think we should do the same with this, so that one can drop multiple builds into a PXE server and not have them conflict. |
I copied some of the commit message from the upstream issue: coreos/fedora-coreos-tracker#161. @imcleod can you clarify on how you use these artifacts?
|
One benefit to producing these individually rather than in a |
Yep, I'm also suggesting adding the version to the kernel/initramfs so that one can safely unpack the tarball into a PXE server directory and not overwrite earlier builds. |
We have a use case to keep them uncompressed and separated for iPXE. I'll just do the rename with the version and keep them separated unless there are objections. |
The iPXE argument makes sense, so SGTM! |
The installer ISO generation already pulls the initramfs and kernel from the ostree repo so this just piggybacks off that and copies the artifacts to the build directory. Having the initramfs and kernel is useful for tools like virt-install and OZ to look at a tree and boot the kernel with fine grain control over the kernel command line. Do not compress the kernel or initramfs.img because they can be used directly by URL in iPXE.
6b3cf09
to
3e8b773
Compare
⬆️ pushed changes for
|
The installer ISO generation already pulls the initramfs and kernel
from the ostree repo so this just piggybacks off that and copies the
artifacts to the build directory. Having the initramfs and kernel is
useful for tools like virt-install and OZ to look at a tree and boot
the kernel with fine grain control over the kernel command line.