Build live PXE and ISO images #738

bgilbert · 2019-09-05T06:39:43Z

Add buildextend command to build live PXE and ISO images, with a squashfs of the root filesystem appended to the initrd. Pursuant to coreos/fedora-coreos-tracker#203, we'd eventually drop the separate installer images.

Part of coreos/fedora-coreos-config#155.

Allow buildextend-installer to be called as "buildextend-live", and adjust the artifact names and meta.json keys accordingly.

src/cmd-buildextend-installer

src/gf-mksquashfs

bgilbert · 2019-09-07T01:00:30Z

Updated.

cgwalters · 2019-09-09T13:17:36Z

Random background thought; given how entangled cosa and the "base" fedora-coreos-config git repos are, I wonder if it'd be cleaner to actually merge the true basics of the config into cosa.

cgwalters

LGTM!

tuan-hoang1 · 2019-09-12T07:23:15Z

GTG @dustymabe ?

dustymabe

here are some initial comments. Will probably have more tomorrow when I test the built artifacts

dustymabe · 2019-09-13T02:54:20Z

src/gf-mksquashfs

+# Work in a tmpdir on the destination so that we don't inherit some MCS labeling
+# from the /tmp dir in the container. This also ensures that the final move is a
+# pure `rename()`.
+# See also: https://github.com/coreos/coreos-assembler/issues/292


can we add a link to #394 as I think that gives us better information now. Whatever changes we make here we should also make in gf-platformid

dustymabe · 2019-09-13T03:08:43Z

src/gf-mksquashfs

+coreos_gf_run_mount "${src}" --ro
+
+# coreos_gf_run_mount helpfully mounted filesystems other than root.
+# We only want root.


maybe it would be simpler just to replace this all with:

coreos_gf_run "${src}" --ro root=$(coreos_gf findfs-label root) coreos_gf mount "${root}" /

dustymabe · 2019-09-13T03:17:37Z

src/cmd-buildextend-installer

@@ -31,32 +31,38 @@ if not args.build:

 print(f"Targeting build: {args.build}")

+# Hacky mode switch, until we can drop support for the installer images


definitely took me a minute looking at the code sideways :) - any idea how long before we can drop the other images?

For FCOS, hopefully soon. For RHCOS it's more of a policy question.

src/gf-mksquashfs

In particular, the caller might want to pass --ro. Also clean up some overly indirect code.

Use guestfish to generate a zstd-compressed squashfs of the root filesystem, then pack it into a cpio archive and append it to the initramfs.

The live image needs different bootloader messages and kargs than the installer.

bgilbert · 2019-09-13T05:26:32Z

Updated.

dustymabe · 2019-09-15T16:33:32Z

We need to update cmd-compress to handle the new types:

$ git diff
diff --git a/src/cmd-compress b/src/cmd-compress
index 7cb7a4d..63262d5 100755
--- a/src/cmd-compress
+++ b/src/cmd-compress
@@ -41,7 +41,7 @@ else:
 print(f"Targeting build: {build}")
 
 # Don't compress certain images
-imgs_to_skip = ["iso", "vmware", "initramfs", "kernel"]
+imgs_to_skip = ["live-iso", "live-kernel", "live-initramfs", "iso", "vmware", "initramfs", "kernel"]
 
 
 def get_cpu_param(param):

dustymabe · 2019-09-15T16:41:45Z

src/gf-mksquashfs

+coreos_gf_run "${src}" --ro
+
+root=$(coreos_gf findfs-label root)
+coreos_gf mount "${root}" /


I know /boot/ won't be used but wondering if we should include it for completeness? Is that was is causing this message:

[core@localhost ~]$ ostree admin status error: Unexpected state: /run/ostree-booted found and in / sysroot but not in a booted deployment

We can't include the kernel and initramfs. We could include everything else, if that's the right way to proceed. Filed as ostreedev/ostree#1921, and let's not block this PR for it.

We already skip the corresponding installer artifacts.

bgilbert · 2019-09-15T18:15:04Z

Good catch on cmd-compress. Updated.

dustymabe

LGTM

bgilbert added 2 commits August 29, 2019 05:06

buildextend-installer: alias to buildextend-live

9a9614f

Allow buildextend-installer to be called as "buildextend-live", and adjust the artifact names and meta.json keys accordingly.

gf-platformid: also fail on xz-compressed images

b03676e

bgilbert mentioned this pull request Sep 5, 2019

[WIP] builtextend: produce a squashfs artifact #261

Closed

cgwalters reviewed Sep 5, 2019

View reviewed changes

src/cmd-buildextend-installer Outdated Show resolved Hide resolved

src/cmd-buildextend-installer Show resolved Hide resolved

src/gf-mksquashfs Outdated Show resolved Hide resolved

cgwalters approved these changes Sep 9, 2019

View reviewed changes

dustymabe self-requested a review September 9, 2019 15:17

bgilbert mentioned this pull request Sep 9, 2019

Initial support for live PXE and ISO images coreos/fedora-coreos-config#155

Merged

tuan-hoang1 mentioned this pull request Sep 11, 2019

s390x: add support for zFCP SCSI and ECKD DASD devices on zVM and LPAR coreos/coreos-installer#61

Merged

dustymabe reviewed Sep 13, 2019

View reviewed changes

bgilbert added 4 commits September 13, 2019 01:24

gf-platformid: add some additional context to a comment

d289bd6

libguestfish: allow extra arguments when starting guestfish

23a35f1

In particular, the caller might want to pass --ro. Also clean up some overly indirect code.

buildextend-live: generate squashfs and add it to initrd

48277ec

Use guestfish to generate a zstd-compressed squashfs of the root filesystem, then pack it into a cpio archive and append it to the initramfs.

buildextend-live: read boot files from distinct dir in config repo

8fc5ec8

The live image needs different bootloader messages and kargs than the installer.

dustymabe reviewed Sep 15, 2019

View reviewed changes

cmd-compress: skip live artifacts

0c5e593

We already skip the corresponding installer artifacts.

dustymabe approved these changes Sep 16, 2019

View reviewed changes

bgilbert merged commit 1c84755 into coreos:master Sep 16, 2019

bgilbert deleted the live branch September 16, 2019 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build live PXE and ISO images #738

Build live PXE and ISO images #738

bgilbert commented Sep 5, 2019

bgilbert commented Sep 7, 2019

cgwalters commented Sep 9, 2019

cgwalters left a comment

tuan-hoang1 commented Sep 12, 2019

dustymabe left a comment

dustymabe Sep 13, 2019

dustymabe Sep 13, 2019

dustymabe Sep 13, 2019

bgilbert Sep 13, 2019

bgilbert commented Sep 13, 2019

dustymabe commented Sep 15, 2019

dustymabe Sep 15, 2019

bgilbert Sep 15, 2019

bgilbert commented Sep 15, 2019

dustymabe left a comment

		@@ -31,32 +31,38 @@ if not args.build:

		print(f"Targeting build: {args.build}")

		# Hacky mode switch, until we can drop support for the installer images

Build live PXE and ISO images #738

Build live PXE and ISO images #738

Conversation

bgilbert commented Sep 5, 2019

bgilbert commented Sep 7, 2019

cgwalters commented Sep 9, 2019

cgwalters left a comment

Choose a reason for hiding this comment

tuan-hoang1 commented Sep 12, 2019

dustymabe left a comment

Choose a reason for hiding this comment

dustymabe Sep 13, 2019

Choose a reason for hiding this comment

dustymabe Sep 13, 2019

Choose a reason for hiding this comment

dustymabe Sep 13, 2019

Choose a reason for hiding this comment

bgilbert Sep 13, 2019

Choose a reason for hiding this comment

bgilbert commented Sep 13, 2019

dustymabe commented Sep 15, 2019

dustymabe Sep 15, 2019

Choose a reason for hiding this comment

bgilbert Sep 15, 2019

Choose a reason for hiding this comment

bgilbert commented Sep 15, 2019

dustymabe left a comment

Choose a reason for hiding this comment