-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd-buildprep: Add --ostree flag to download full commit #746
Conversation
Add an `--ostree` flag to also download the OSTree commit. This is needed to close a gap where only the image input changed, so no new OSTree content is created, and so we need the full OSTree content in order to build the new images.
What are the sources of image input change today? |
Are you proposing we use this in the fcos pipeline today to handle a gap in our logic where the image.yaml changes but the ostree doesn't? I'm trying to imagine exactly where we are going to use this. |
Yeah, and the commit itself.
I'm adding the flag for completeness and so we can at least ask that question. I don't have a strong opinion on whether we should use it in the pipeline. It's a corner case, and in practice, we can always force a rebuild if it's a prod release and e.g. we do a final tweak to Thinking more on this, we could download the commit only if we need it. I'm not convinced it's worth the added complexity though. |
Is there a case where we run the pipeline it creates a commit and image.yaml (call it 30.20190912.0) and then we immediately change the image.yaml and run it again. What would you expect to happen in that case?
|
This is an interesting corner case that is explicitly handled by the build code today - you get a |
Right, this brings up an interesting side of this discussion, which is that for FCOS, we'd like to not have So this argues for not using it in the pipeline, so that we don't mistakenly hit this until we implement external versioning control. (That said, there's no reason why |
Add an
--ostree
flag to also download the OSTree commit. This isneeded to close a gap where only the image input changed, so no new
OSTree content is created, and so we need the full OSTree content in
order to build the new images.